Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 194 insertions(+))
google-beta provider: Diff ( 6 files changed, 923 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 111 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_reference_list (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_reference_list" "primary" {
  scope_info {
    reference_list_scope {
      scope_names = # value needed
    }
  }
}

Tests analytics

Total tests: 13
Passed tests: 11
Skipped tests: 0
Affected tests: 2

Action taken

Get to know how VCR tests work

🟢 Tests passed during RECORDING mode:
TestAccChronicleReferenceList_chronicleReferencelistBasicExample [Debug log]
TestAccChronicleReferenceList_chronicleReferencelistBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 194 insertions(+))
google-beta provider: Diff ( 6 files changed, 923 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 111 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_reference_list (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_reference_list" "primary" {
  scope_info {
    reference_list_scope {
      scope_names = # value needed
    }
  }
}

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

🟢 All tests passed!

View the build log

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 194 insertions(+)) google-beta provider: Diff ( 6 files changed, 923 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 111 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_reference_list (3 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_reference_list" "primary" {
  scope_info {
    reference_list_scope {
      scope_names = # value needed
    }
  }
}

scope_info is an Output only field, hence no tests for this.

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 193 insertions(+))
google-beta provider: Diff ( 6 files changed, 921 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 111 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_reference_list (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_reference_list" "primary" {
  scope_info {
    reference_list_scope {
      scope_names = # value needed
    }
  }
}

Tests analytics

Total tests: 17
Passed tests: 15
Skipped tests: 0
Affected tests: 2

Action taken

Get to know how VCR tests work

🟢 Tests passed during RECORDING mode:
TestAccChronicleReferenceList_chronicleReferencelistBasicExample [Debug log]
TestAccChronicleReferenceList_chronicleReferencelistBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

No, we don't have any specific guide for reference list. This generic guide is added on purpose.

@ronakgadia , can you review the PR? Thanks.

@ronakgadia , can you review the PR? Thanks.

Hi @zli82016, Ronak has already reviewed the changes: https://screenshot.googleplex.com/6emB7z7F7kGTTMy